Skip to content

Resolve type error when running JS tests locally #24026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
2 commits merged into from
Jul 16, 2020
Merged

Resolve type error when running JS tests locally #24026

2 commits merged into from
Jul 16, 2020

Conversation

captainsafia
Copy link
Member

Imports the type declaration that adds BINDING to the global object to ensure that the tests can run locally.

Resolves the following issue that we currently have when running JS tests locally.

    TypeScript diagnostics (customize using `[jest-config].globals.ts-jest.diagnostics` option):
    src/Platform/Profiling.ts:127:44 - error TS2304: Cannot find name 'BINDING'.

    127     return typeof str === 'string' ? str : BINDING.conv_string(str);

@captainsafia captainsafia requested review from SteveSandersonMS and a team as code owners July 16, 2020 18:07
@ghost ghost added the area-blazor Includes: Blazor, Razor Components label Jul 16, 2020
Copy link
Member

@SteveSandersonMS SteveSandersonMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ghost
Copy link

ghost commented Jul 16, 2020

Hello @captainsafia!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 60 minutes, a condition that will be fulfilled in about 32 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 049f421 into master Jul 16, 2020
@ghost ghost deleted the safia/fix-tests branch July 16, 2020 22:20
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-blazor Includes: Blazor, Razor Components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants