Turn on nullability for Routing #24238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
pranavkm
force-pushed
the
prkrishn/fix-nullability
branch
2 times, most recently
from
ca88610 to
072ddaa
Compare
JamesNK
reviewed
Jul 23, 2020
JamesNK
reviewed
Jul 24, 2020
| @@ -14,7 +14,7 @@ public class BoolRouteConstraint : IRouteConstraint | |||
| { | |||
| /// <inheritdoc /> | |||
| public bool Match( | |||
| HttpContext httpContext, | |||
| HttpContext? httpContext, | |||
| IRouter route, | |||
There was a problem hiding this comment.
Can route and routeKey be null? I would have thought endpoint routing would pass a null route (or maybe it is a dummy one)
There was a problem hiding this comment.
IRouter could be null, but routeKey is required by all of the built-in constraints.
| @@ -90,11 +90,11 @@ public LengthRouteConstraint(int minLength, int maxLength) | |||
| if (values.TryGetValue(routeKey, out var value) && value != null) | |||
| { | |||
| var valueString = Convert.ToString(value, CultureInfo.InvariantCulture); | |||
| var length = valueString.Length; | |||
| var length = valueString!.Length; | |||
There was a problem hiding this comment.
nit: put the ! on Convert.ToString
src/Http/Routing/src/LinkGeneratorRouteValuesAddressExtensions.cs
Outdated
Show resolved
Hide resolved
| { | ||
| // Friendliness for inlining | ||
| if ((uint)index >= Count) | ||
| { | ||
| ThrowIndexArgumentOutOfRangeException(); | ||
| } | ||
|
|
||
| Candidates[index] = new CandidateState(endpoint, values, Candidates[index].Score); | ||
| Candidates[index] = new CandidateState(endpoint!, values, Candidates[index].Score); |
There was a problem hiding this comment.
ReplaceEndpoint has Endpoint? endpoint then CandidateState requires it not be null. Which is true?
There was a problem hiding this comment.
Updated CandidateSet
pranavkm
force-pushed
the
prkrishn/fix-nullability
branch
2 times, most recently
from
f2f0c59 to
d10a6ee
Compare
JamesNK
approved these changes
Jul 24, 2020
pranavkm
force-pushed
the
prkrishn/fix-nullability
branch
from
d10a6ee to
fab7ed7
Compare
We previously only had annotations enabled which resulted in incorrect nullability. This change enables nullability. Fixes #24042
pranavkm
force-pushed
the
prkrishn/fix-nullability
branch
from
fab7ed7 to
cf03192
Compare
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously only had annotations enabled which resulted in incorrect nullability. This change enables
nullability.
Fixes #24042