Skip to content

Revert "Try using helix sdk support directly again (#23585)" #24250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
1 commit merged into from
Jul 23, 2020
Merged

Conversation

HaoK
Copy link
Member

@HaoK HaoK commented Jul 23, 2020

This reverts commit 059fe39.

Backing out until helix-matrix is working as well

@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jul 23, 2020
@HaoK HaoK requested review from sebastienros and a team July 23, 2020 20:08
@ghost
Copy link

ghost commented Jul 23, 2020

Hello @HaoK!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 60 minutes, a condition that will be fulfilled in about 51 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

Copy link
Member

@sebastienros sebastienros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't disagree if it fixes the builds !

@ghost ghost merged commit d9049ec into master Jul 23, 2020
@ghost ghost deleted the haok/backup branch July 23, 2020 22:47
@sebastienros
Copy link
Member

Did it just got merged automatically because I approved?

@HaoK
Copy link
Member Author

HaoK commented Jul 23, 2020

No I used auto-merge so the bot was just waiting for the checks to pass

HaoK added a commit that referenced this pull request Jul 24, 2020
HaoK added a commit that referenced this pull request Jul 27, 2020
HaoK added a commit that referenced this pull request Aug 11, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants