Use BlazorWebAssemblySDK #24371
Use BlazorWebAssemblySDK #24371
Conversation
pranavkm
commented
Jul 28, 2020
pranavkm
commented
- Update projects to use the BlazorSDK
- Remove tasks and targets from RazorSDK
- Remove workarounds from BlazorSDK
pranavkm
force-pushed
the
prkrishn/use-blazor-sdk
branch
from
5686433 to
76d01f7
Compare
| @@ -12,7 +12,7 @@ | |||
| <PackageReference Include="MicroBuild.Core" Version="0.3.0" PrivateAssets="All" AllowExplicitReference="true" ExcludeAssets="All" /> | |||
| </ItemGroup> | |||
|
|
|||
| <ItemGroup Condition="'$(UsingMicrosoftNETSdkWeb)' == 'true' OR '$(RazorSdkCurrentVersionProps)' != ''"> | |||
| <ItemGroup Condition="'$(UsingMicrosoftNETSdkWeb)' == 'true' OR '$(UsingMicrosoftNETSdkBlazorWebAssembly)' == 'true' OR '$(RazorSdkCurrentVersionProps)' != ''"> | |||
There was a problem hiding this comment.
Why are we bringing back the UsingMicrosoftNETSdkBlazorWebAssembly property?
There was a problem hiding this comment.
This might be to prevent double imports?
There was a problem hiding this comment.
This is set in the SDK similar to other SDKs
| @@ -701,6 +705,8 @@ public async Task Publish_HostedApp_VisualStudio_WithSatelliteAssemblies() | |||
| var existing = File.ReadAllText(blazorwasmProjFile); | |||
| var updatedContent = @" | |||
| <PropertyGroup> | |||
| <!-- Workaround for https://github.com/mono/linker/issues/1390 --> | |||
There was a problem hiding this comment.
It looks like the referenced issue was fixed. Do we need this workaround because the fix isn't shipped?
There was a problem hiding this comment.
Do we need this workaround because the fix isn't shipped?
Yup. Waiting for the fix to get to the .net sdk
pranavkm
force-pushed
the
prkrishn/use-blazor-sdk
branch
from
f510ad5 to
31d0956
Compare
|
|
||
| <PropertyGroup> | ||
| <TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework> | ||
| <RuntimeIdentifier>browser-wasm</RuntimeIdentifier> | ||
| <UseBlazorWebAssembly>true</UseBlazorWebAssembly> | ||
| <FixupWebAssemblyHttpHandlerReference>true</FixupWebAssemblyHttpHandlerReference> | ||
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> |
There was a problem hiding this comment.
This is a very nice looking csproj now!
There was a problem hiding this comment.
So nice to see all the code get deleted! This is a great payoff from your SDK work. Great stuff @pranavkm!
I'm not in a position to absolutely evaluate the correctness of every aspect of this since nobody could know what are all the consequences of different MSBuild properties/tweaks, however I'm approving on the basis that you know what you're doing and morally speaking all the changes here look good to me.
|
Hello @pranavkm! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
pranavkm
force-pushed
the
prkrishn/use-blazor-sdk
branch
from
31d0956 to
64b95b9
Compare
* Update projects to use the BlazorSDK * Remove tasks and targets from RazorSDK * Remove workarounds from BlazorSDK
pranavkm
force-pushed
the
prkrishn/use-blazor-sdk
branch
2 times, most recently
from
5ffbca1 to
0a9245f
Compare
pranavkm
force-pushed
the
prkrishn/use-blazor-sdk
branch
from
0a9245f to
9b2cb5b
Compare
ghost
merged commit 
