Turn off full GC #24545
Merged
Turn off full GC #24545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the full gc sometimes leads to an infinite recursion resulting in a browser freeze. This was noted as part of running Blazor's benchmarks. This is being addressed in rc1, in the meanwhile this reverts the behavior to 3.2 defaults. Browser freezes when using a Blazor WASM application. Yes. Full GC on is new to WASM on .NET Core Low. Off by default is the behavior we had in 3.2.
ghost
added
the
lewing
approved these changes
Aug 3, 2020
vargaz
approved these changes
Aug 3, 2020
mkArtakMSFT
added
the
Servicing-consider
|
Hello human! Please make sure you've included the Shiproom Template in a comment or (preferably) the PR description. Also, make sure this PR is not marked as a draft and is ready-to-merge. |
mkArtakMSFT
added
ask-mode
|
Thanks @pranavkm! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Using the full gc sometimes leads to an infinite recursion resulting
in a browser freeze. This was noted as part of running Blazor's benchmarks.
This is being addressed in rc1, in the meanwhile this reverts the behavior to 3.2 defaults.
Customer impact
Browser freezes when using a Blazor WASM application.
Regression
Yes. Full GC on is new to WASM on .NET Core
Risk
Low. Off by default is the behavior we had in 3.2.