Skip to content

Remove Blazor internal profiling infrastructure (#24468) #24589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 5, 2020
Merged

Remove Blazor internal profiling infrastructure (#24468) #24589

merged 1 commit into from
Aug 5, 2020

Conversation

pranavkm
Copy link
Contributor

@pranavkm pranavkm commented Aug 5, 2020 •
edited
Loading

  • Put back InternalCalls

  • Removing .NET profiling calls

  • Remove JS side profiling

Porting 6f7a3df to preview8

@SteveSandersonMS @pranavkm
Remove Blazor internal profiling infrastructure (#24468)
19a197e 
* Put back InternalCalls

* Removing .NET profiling calls

* Remove JS side profiling
@pranavkm pranavkm requested review from SteveSandersonMS and a team as code owners August 5, 2020 17:51
@ghost ghost added the area-blazor Includes: Blazor, Razor Components label Aug 5, 2020
@pranavkm pranavkm added this to the 5.0.0-preview8 milestone Aug 5, 2020
@pranavkm
Copy link
Contributor Author

pranavkm commented Aug 5, 2020

Description

This removes the internal profiling infrastructure previously added in #23510, because:

Customer impact

Issue #24339 was detected as part of app-compat testing.

Regression

Yes. These APIs were new to preview8.

Risk

Low. This removes internal infrastructure that is already being removed from rc.

@mkArtakMSFT mkArtakMSFT added the Servicing-consider Shiproom approval is required for the issue label Aug 5, 2020
@ghost
Copy link

ghost commented Aug 5, 2020

Hello human! Please make sure you've included the Shiproom Template in a comment or (preferably) the PR description. Also, make sure this PR is not marked as a draft and is ready-to-merge.

@mkArtakMSFT mkArtakMSFT added Servicing-approved Shiproom has approved the issue and removed Servicing-consider Shiproom approval is required for the issue labels Aug 5, 2020
mkArtakMSFT
mkArtakMSFT approved these changes Aug 5, 2020
View reviewed changes
Copy link
Contributor

@mkArtakMSFT mkArtakMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pranavkm !

@mkArtakMSFT mkArtakMSFT merged commit b654051 into release/5.0-preview8 Aug 5, 2020
@mkArtakMSFT mkArtakMSFT deleted the prkrishn/port-fix branch August 5, 2020 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkArtakMSFT mkArtakMSFT mkArtakMSFT approved these changes

@SteveSandersonMS SteveSandersonMS Awaiting requested review from SteveSandersonMS

Assignees
No one assigned
Labels
area-blazor Includes: Blazor, Razor Components Servicing-approved Shiproom has approved the issue
Projects
None yet
Milestone
5.0.0-preview8
Development

Successfully merging this pull request may close these issues.
3 participants
@pranavkm @mkArtakMSFT @SteveSandersonMS