Skip to content

Quarantine tests #24757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
5 commits merged into from
Aug 11, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Components/test/E2ETest/Tests/BindTest.cs
Original file line number Diff line number Diff line change
Expand Up @@ -612,6 +612,7 @@ public void CanBindTextboxNullableDecimal()
// This tests what happens you put invalid (unconvertable) input in. This is separate from the
// other tests because it requires type="text" - the other tests use type="number"
[Fact]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/24756")]
public void CanBindTextbox_Decimal_InvalidInput()
{
var target = Browser.FindElement(By.Id("textbox-decimal-invalid"));
Expand Down
1 change: 1 addition & 0 deletions src/Components/test/E2ETest/Tests/KeyTest.cs
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,7 @@ public void CanDeleteUnkeyed()
}

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/24190")]
public void CanReorder()
{
PerformTest(
Expand Down
1 change: 1 addition & 0 deletions src/Hosting/test/FunctionalTests/LinkedApplicationTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ namespace Microsoft.AspNetCore.Hosting.FunctionalTests
{
public class LinkedApplicationTests : LoggedTest
{
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/24755")]
[Fact]
public async Task LinkedApplicationWorks()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI @jkotalik

{
Expand Down
2 changes: 1 addition & 1 deletion src/Servers/HttpSys/test/FunctionalTests/ServerTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -320,7 +320,7 @@ public async Task Server_Abort_CallCanceled()
using (var client = await SendHungRequestAsync("GET", address))
{
await received.Task.TimeoutAfter(interval);
Assert.Throws<IOException>(() => client.GetStream().Read(new byte[10], 0, 10));
Assert.ThrowsAny<IOException>(() => client.GetStream().Read(new byte[10], 0, 10));
}
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ public async Task ThrowingSynchronousConnectionMiddlewareDoesNotCrashServer()
using (var connection = server.CreateConnection())
{
// Will throw because the exception in the connection adapter will close the connection.
await Assert.ThrowsAsync<IOException>(async () =>
await Assert.ThrowsAnyAsync<IOException>(async () =>
{
await connection.Send(
"POST / HTTP/1.0",
Expand Down