Skip to content

Fix flaky keepalive ping test #24804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
2 commits merged into from
Aug 12, 2020
Merged

Fix flaky keepalive ping test #24804

2 commits merged into from
Aug 12, 2020

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Aug 11, 2020

Fixes #24797

@ghost
Copy link

ghost commented Aug 11, 2020

Hello @Tratcher!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 57b5321 into master Aug 12, 2020
@ghost ghost deleted the jamesnk/nokeepalivetimeout-flaky branch August 12, 2020 00:23
JamesNK added a commit that referenced this pull request Aug 13, 2020
* Fix flaky keepalive ping test

* Clean up stream
wtgodbe pushed a commit that referenced this pull request Aug 13, 2020
* Reset KeepAliveTimeout on HTTP/2 ping (#24644)

* Fix flaky keepalive ping test (#24804)

* Fix flaky keepalive ping test

* Clean up stream

* Remove quarantine attribute

* Fix test
@JamesNK JamesNK added this to the 5.0.0-rc1 milestone Aug 14, 2020
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 6, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test failure: PING_NoKeepAliveTimeout_DoesNotResetKeepAliveTimeout
3 participants