Skip to content

[release/5.0] Enable MUSL ARM support #27942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 23, 2020

Conversation

janvorli
Copy link
Member

@janvorli janvorli commented Nov 18, 2020

Port of #26281

Description

This change adds support for building MUSL ARM packages of ASP.NET Core.

Runtime repo has support for MUSL ARM in the 5.0 GA release, but this repo was missing it by accident. That prevent us from creating Linux Alpine ARM docker images for .NET 5.0.

Customer Impact

The change enables customers to use .NET Core in very small memory footprint Alpine ARM32 container.

Regression?

No

Risk

Low, this is a new platform enabling and changes are not influencing existing platforms.

This change adds support for building MUSL ARM packages of ASP.NET Core.
@janvorli janvorli added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Nov 18, 2020
@janvorli janvorli added this to the 5.0.1 milestone Nov 18, 2020
@janvorli janvorli requested a review from dougbu November 18, 2020 15:57
@janvorli janvorli self-assigned this Nov 18, 2020
@janvorli
Copy link
Member Author

cc: @Pilchie

I am not sure what is the right label in this repo to mark this change - I've seen that at least some porting changes have "tell mode" label, but I can also see there is "servicing consider" label that we use for porting to servicing releases in the runtime repo.

@Pilchie
Copy link
Member

Pilchie commented Nov 18, 2020

I think since this changes platform coverage, we should use servicing consider so that this is raised to Tactics awareness.

@Pilchie
Copy link
Member

Pilchie commented Nov 18, 2020

tell-mode is normally only for pure infrastructure or test changes that don't require tactics approval.

@janvorli
Copy link
Member Author

Thank you @Pilchie!

@janvorli janvorli added the Servicing-consider Shiproom approval is required for the issue label Nov 18, 2020
@ghost
Copy link

ghost commented Nov 18, 2020

Hello human! Please make sure you've included the Shiproom Template in a comment or (preferably) the PR description. Also, make sure this PR is not marked as a draft and is ready-to-merge.

Copy link
Contributor

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very familiar 😺

@janvorli
Copy link
Member Author

@dougbu I can see that three legs have failed in the CI. I've tried to re-run them, but they've failed again. Could you please take look at the failures to see if they can be related to my change somehow? I have inspected the logs, but I am not familiar with aspnetcore enough to be able to tell what's wrong.

@dougbu
Copy link
Contributor

dougbu commented Nov 20, 2020

@janvorli watch #28001. Once @captainsafia gets that in, do the /azp run thing 😺

BTW Steve approved this PR in email earlier today.

@janvorli
Copy link
Member Author

@dougbu thank you!

@captainsafia
Copy link
Member

Good to go now! :)

/azp run

@captainsafia
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@janvorli janvorli closed this Nov 23, 2020
@janvorli janvorli reopened this Nov 23, 2020
@Pilchie Pilchie added Servicing-approved Shiproom has approved the issue and removed Servicing-consider Shiproom approval is required for the issue labels Nov 23, 2020
@Pilchie
Copy link
Member

Pilchie commented Nov 23, 2020

This was approved by Tactics over email and should be merged when green.

@janvorli
Copy link
Member Author

@Pilchie, @dougbu it just got green, could one of you please merge it in?

@Pilchie Pilchie merged commit 045882a into dotnet:release/5.0 Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework Servicing-approved Shiproom has approved the issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants