-
Notifications
You must be signed in to change notification settings - Fork 10.4k
[release/5.0] Enable MUSL ARM support #27942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/5.0] Enable MUSL ARM support #27942
Conversation
This change adds support for building MUSL ARM packages of ASP.NET Core.
cc: @Pilchie I am not sure what is the right label in this repo to mark this change - I've seen that at least some porting changes have "tell mode" label, but I can also see there is "servicing consider" label that we use for porting to servicing releases in the runtime repo. |
I think since this changes platform coverage, we should use |
|
Thank you @Pilchie! |
Hello human! Please make sure you've included the Shiproom Template in a comment or (preferably) the PR description. Also, make sure this PR is not marked as a draft and is ready-to-merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very familiar 😺
@dougbu I can see that three legs have failed in the CI. I've tried to re-run them, but they've failed again. Could you please take look at the failures to see if they can be related to my change somehow? I have inspected the logs, but I am not familiar with aspnetcore enough to be able to tell what's wrong. |
@janvorli watch #28001. Once @captainsafia gets that in, do the BTW Steve approved this PR in email earlier today. |
@dougbu thank you! |
Good to go now! :) /azp run |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
This was approved by Tactics over email and should be merged when green. |
Port of #26281
Description
This change adds support for building MUSL ARM packages of ASP.NET Core.
Runtime repo has support for MUSL ARM in the 5.0 GA release, but this repo was missing it by accident. That prevent us from creating Linux Alpine ARM docker images for .NET 5.0.
Customer Impact
The change enables customers to use .NET Core in very small memory footprint Alpine ARM32 container.
Regression?
No
Risk
Low, this is a new platform enabling and changes are not influencing existing platforms.