Skip to content

Use a single request object #28347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
1 commit merged into from
Dec 5, 2020
Merged

Use a single request object #28347

1 commit merged into from
Dec 5, 2020

Conversation

davidfowl
Copy link
Member

@davidfowl davidfowl commented Dec 3, 2020 •
edited
Loading

  • Merged NativeRequestContext, RequestContext and FeatureContext into a single object.
    • RequestContext derives from NativeRequestContext

Contributes to #22022

gfoidl
gfoidl reviewed Dec 3, 2020
View reviewed changes
Copy link
Member

@gfoidl gfoidl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small nit.

Tratcher
Tratcher reviewed Dec 3, 2020
View reviewed changes
@davidfowl davidfowl force-pushed the davidfowl/merge-contexts branch from 3a0f794 to f1b1e19 Compare December 4, 2020 03:24
Tratcher
Tratcher approved these changes Dec 4, 2020
View reviewed changes
@davidfowl davidfowl mentioned this pull request Dec 4, 2020
Merged
Base automatically changed from davidfowl/accept-loop to master December 4, 2020 21:45
@davidfowl
Use a single request object
66cf00a 
- Merged NativeRequestContext, RequestContext and FeatureContext into a single object.
@davidfowl davidfowl force-pushed the davidfowl/merge-contexts branch from eea77c3 to 66cf00a Compare December 5, 2020 02:41
@ghost
Copy link

ghost commented Dec 5, 2020

Hello @davidfowl!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit b6be6be into master Dec 5, 2020
@ghost ghost deleted the davidfowl/merge-contexts branch December 5, 2020 05:32
@davidfowl davidfowl added this to the 6.0-preview1 milestone Dec 11, 2020
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 6, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tratcher Tratcher Tratcher approved these changes

@gfoidl gfoidl gfoidl left review comments

@halter73 halter73 Awaiting requested review from halter73

@jkotalik jkotalik Awaiting requested review from jkotalik

Assignees
No one assigned
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Projects
None yet
Milestone
6.0-preview1
Development

Successfully merging this pull request may close these issues.
5 participants
@davidfowl @Tratcher @gfoidl @Pilchie @amcasey