Skip to content

[release/2.1] Update Node dependencies for Angular template #29832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 10, 2021

Conversation

captainsafia
Copy link
Member

Description

  • Update dependencies to their latest patch release via npm updated
  • Update dependencies with known security issues via npm audit fix

Customer Impact

This PR includes some routine updates to the Node packages that we reference in the Angular template. Customers can apply these updates on their own but including them as part of the template reduces the friction for using these templates.

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Most package updates are for minor/path versions.

Verification

  • Manual (required)
  • Automated

Manual validation completed via:

$ dotnet new angular
$ dotnet run

Packaging changes reviewed?

  • Yes
  • No
  • N/A

@captainsafia captainsafia added the tell-mode Indicates a PR which is being merged during tell-mode label Feb 1, 2021
@captainsafia captainsafia changed the title Update Node dependencies for Angular template [release/2.1] Update Node dependencies for Angular template Feb 1, 2021
Copy link
Contributor

@ryanbrandenburg ryanbrandenburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Pilchie Pilchie added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Feb 2, 2021
@mkArtakMSFT mkArtakMSFT added this to the 2.1.x milestone Feb 2, 2021
Copy link
Contributor

@mkArtakMSFT mkArtakMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @captainsafia !

@BrennanConroy
Copy link
Member

I don't know how templates are shipped, do they need to be included in the patch.config? @dotnet/aspnet-build

@wtgodbe
Copy link
Member

wtgodbe commented Feb 3, 2021

I don't know how templates are shipped, do they need to be included in the patch.config? @dotnet/aspnet-build

Looks like this build produced the package without it needing to be in patchConfig. Looking at old 2.1 drops, it seems that we produce the template packages every time.

@wtgodbe
Copy link
Member

wtgodbe commented Feb 3, 2021

@captainsafia
Copy link
Member Author

@wtgodbe I think this is ready to go now? I'm not sure if your comments above indicate there is more work to do here.

@wtgodbe wtgodbe merged commit 8e5e509 into release/2.1 Feb 10, 2021
@wtgodbe wtgodbe deleted the safia/angular-updates-2.1 branch February 10, 2021 23:50
@dougbu dougbu modified the milestones: 2.1.x, 2.1.26 Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates tell-mode Indicates a PR which is being merged during tell-mode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants