-
Notifications
You must be signed in to change notification settings - Fork 10.4k
Port duplication of productVersion.txt to release/5.0 #30124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
wtgodbe
merged 1 commit into
dotnet:release/5.0
from
michellemcdaniel:renameProductVersion5.0
Feb 12, 2021
Merged
Port duplication of productVersion.txt to release/5.0 #30124
wtgodbe
merged 1 commit into
dotnet:release/5.0
from
michellemcdaniel:renameProductVersion5.0
Feb 12, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Duplicate productVersion.txt with repo-specific name
wtgodbe
approved these changes
Feb 11, 2021
This was referenced Mar 10, 2021
Closed
Closed
Closed
This was referenced Mar 15, 2021
Closed
Closed
Closed
Bump Microsoft.AspNetCore.Components.WebAssembly.Server from 5.0.3 to 5.0.4
aleks-ivanov/MudBlazor#5
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area-infrastructure
Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
tell-mode
Indicates a PR which is being merged during tell-mode
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Title
Port duplication of productVersion.txt to release/5.0
PR Description
In our efforts to unify the build access story using aka.ms links, we have found that there are certain files that share the same name in multiple different repositories, most importantly, productVersion.txt. As part of the work to move to aka.ms links, we will be flattening the short link paths, so rather than having a runtime-specific, aspnetcore-specific, etc. full path to the files generated by each of the repos, they will all go to the same short link location. This means that the path to productVersion.txt will collide in the aka.ms links (the backing locations are not changing and will be unaffected). To combat this, we will add a duplicate of each of the product repos productVersion.txt, renamed to indicate which product repo it came from, in this case aspnetcore-productVersion.txt. The original will remane so that we do not break existing scenarios that do not use the aka.ms links.
Addresses dotnet/arcade#6862