-
Notifications
You must be signed in to change notification settings - Fork 10.4k
Added IConnectionSocketFeature for exposing underlying Socket! #30803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
ShreyasJejurkar
wants to merge
14
commits into
dotnet:main
from
ShreyasJejurkar:connection-socket-feature
Closed
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
c232fd1
Added IConnectionSocketFeature for exposing underlying Socket!
ShreyasJejurkar 8e73961
Readonly Socket !
ShreyasJejurkar 09840e5
Revert "Readonly Socket !"
ShreyasJejurkar b320450
Addressed PR feedback!
ShreyasJejurkar 703511e
Cleanup - Unwanted usings
ShreyasJejurkar e7b6a95
Addressed PR feedback.
ShreyasJejurkar b211ce0
Addressed PR feedback.
ShreyasJejurkar f1f01da
Addressed PR feedback.
ShreyasJejurkar 67128d2
Merge branch 'connection-socket-feature' of https://github.com/MCCshr…
ShreyasJejurkar ea59c5b
Added socket finally! :)
ShreyasJejurkar 4b90693
Addressed PR feedback.
ShreyasJejurkar ad3fe21
Addressed PR feedback.
ShreyasJejurkar b045329
Merge branch 'main' into connection-socket-feature
ShreyasJejurkar 2c39ec4
Update TransportConnection.Generated.cs
ShreyasJejurkar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
18 changes: 18 additions & 0 deletions
18
src/Servers/Connections.Abstractions/src/Features/IConnectionSocketFeature.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
// Copyright (c) .NET Foundation. All rights reserved. | ||
// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information. | ||
|
||
using System.Net.Sockets; | ||
|
||
namespace Microsoft.AspNetCore.Connections.Features | ||
{ | ||
/// <summary> | ||
/// Provides access to the connection's underlying <see cref="Socket"/> if any. | ||
/// </summary> | ||
public interface IConnectionSocketFeature | ||
{ | ||
/// <summary> | ||
/// Gets the underlying <see cref="Socket"/>. | ||
/// </summary> | ||
Socket? Socket { get; } | ||
} | ||
} |
2 changes: 2 additions & 0 deletions
2
src/Servers/Connections.Abstractions/src/PublicAPI.Unshipped.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.