Skip to content

Update to react 17.0 #32045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 7, 2021
Merged

Update to react 17.0 #32045

merged 6 commits into from
May 7, 2021

Conversation

HaoK
Copy link
Member

@HaoK HaoK commented Apr 21, 2021

@ghost ghost added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Apr 21, 2021
@HaoK
Copy link
Member Author

HaoK commented May 7, 2021

@javiercn here's a project that's the output of these changes with individual auth: https://github.com/HaoK/Random/tree/haok/temp/reactind

I verified that things seemed to work via
dotnet run
npm run build
npm run test
npm run lint
npm run start

There are a bunch of npm audit errors related to https://npmjs.com/advisories/1677 but its not clear to me how to manually fix those (I tried explicitly installing hosted-git-info, but that didn't help, guessing its all the packages that use it that also need updating), we can do that in a follow up PR since things are working right now

@javiercn
Copy link
Member

javiercn commented May 7, 2021

Looks great! I imagine this one is much easier to update because the react template is pretty much barebones

@HaoK HaoK marked this pull request as ready for review May 7, 2021 16:52
@HaoK HaoK merged commit 23d7fb4 into main May 7, 2021
@HaoK HaoK deleted the haok/react branch May 7, 2021 16:53
@ghost ghost added this to the 6.0-preview5 milestone May 7, 2021
@HaoK HaoK linked an issue May 7, 2021 that may be closed by this pull request
@f-nicefield-esdc
Copy link

Why not use UseReactDevelopmentServer anymore

@ghost
Copy link

ghost commented Jan 7, 2022

Hi @f-nicefield-esdc. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates feature-spa
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to React 17
3 participants