Turn on TreatWarningsAsErrors since they are currently harmless #32166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Was anything done to fix LinkedApplicationWorks? |
|
No I'm just turning it back on to see if it resolved itself. Lots of changes were made to .NET Core wrt trimming. Though I might take a look at how aggressively this trims and scale it back a bit. Here are the list of warnings that need to be fixed (well some of them need to be suppressed): |
pranavkm
approved these changes
Apr 26, 2021
Do we have an issue to track resolving these? |
eerhardt
reviewed
Apr 26, 2021
src/Hosting/test/testassets/BasicLinkedApp/BasicLinkedApp.csproj
Outdated
Show resolved
Hide resolved
eerhardt
approved these changes
Apr 26, 2021
Merged
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to fix #24755