Skip to content

Add Microsoft.Extensions.Features to Kestrel slnf #32204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
1 commit merged into from
Apr 27, 2021

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Apr 27, 2021

Fixes Kestrel.sln failing to build after git clean

@ghost ghost added the area-runtime label Apr 27, 2021
@ghost
Copy link

ghost commented Apr 27, 2021

Hello @JamesNK!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 60 minutes, a condition that will be fulfilled in about 29 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 5065fd8 into main Apr 27, 2021
@ghost ghost deleted the jamesnk/kestrel-features-slnf branch April 27, 2021 07:10
@davidfowl
Copy link
Member

@Pilchie do you know if there's a way to automate these things? It's super annoying. I'm sure this needs to be added to basically all the slnf files and nothing builds in VS anymore.

@Pilchie
Copy link
Member

Pilchie commented Apr 27, 2021

Here's the options I can think of:

  1. Load each slnf in VS and right click on a project and choose "Load All Dependencies"
  2. Parse the project files yourself (or with msbuild, Roslyn's MSBuildWorkspace, etc), find the dependencies and write them.
  3. git grep for the project that was split in slnf files, and then add the new project to all of them (assumes we had it mostly right before).

@davidfowl
Copy link
Member

@Tratcher can you add these references to all of the slnf files in the repo? I'm guessing everything is broken now without them. We should file an infrastructure issue for doing this.

cc @dougbu

@Tratcher
Copy link
Member

I'll take a look

@dougbu
Copy link
Contributor

dougbu commented May 3, 2021

do you know if there's a way to automate these things?

Note we have a number of *NoDeps.slnf files which intentionally do not include all dependencies. The expectation is probably that users of those solution filters would execute build.cmd in (say) src/Mvc/ before using startvs.cmd there.

@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 6, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants