Skip to content

Add a modification policy to HeaderNames #32394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 4, 2021
Merged

Add a modification policy to HeaderNames #32394

merged 2 commits into from
May 4, 2021

Conversation

Tratcher
Copy link
Member

@Tratcher Tratcher commented May 4, 2021

We don't intend to accept arbitrary additions to this list of headers. I've added a policy statement that we can reference to answer future questions like #32171.

@Tratcher Tratcher added this to the 6.0-preview5 milestone May 4, 2021
@Tratcher Tratcher requested a review from shirhatti May 4, 2021 16:32
@Tratcher Tratcher requested a review from jkotalik as a code owner May 4, 2021 16:32
@Tratcher Tratcher self-assigned this May 4, 2021
@ghost ghost added the area-runtime label May 4, 2021
@Tratcher Tratcher requested a review from halter73 May 4, 2021 16:33
jkotalik
jkotalik approved these changes May 4, 2021
View reviewed changes
shirhatti
shirhatti approved these changes May 4, 2021
View reviewed changes
Copy link
Contributor

@shirhatti shirhatti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
We've done the same for MIME types in the past, but people seem to ignore it 🤷

@Tratcher
Copy link
Member Author

Tratcher commented May 4, 2021

We've done the same for MIME types in the past, but people seem to ignore it 🤷

But at least we can reference it when closing PRs 😁.

@Tratcher Tratcher merged commit 4629299 into main May 4, 2021
@Tratcher Tratcher deleted the tratcher/headers branch May 4, 2021 19:01
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirhatti shirhatti shirhatti approved these changes

@jkotalik jkotalik jkotalik approved these changes

@halter73 halter73 Awaiting requested review from halter73 halter73 is a code owner

Assignees

@Tratcher Tratcher

Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Projects
None yet
Milestone
6.0-preview5
Development

Successfully merging this pull request may close these issues.
4 participants
@Tratcher @shirhatti @jkotalik @amcasey