Refactor WebAssemblyHotReload to use the agent code from the SDK #32496
Conversation
* React to MetadataUpdateHandler renames Contributes to dotnet/runtime#51545
| using System.Reflection.Metadata; | ||
| using Microsoft.AspNetCore.Components.HotReload; | ||
|
|
||
| [assembly: AssemblyMetadata("ReceiveHotReloadDeltaNotification", "Microsoft.AspNetCore.Components.HotReload.HotReloadManager")] |
There was a problem hiding this comment.
This is unused. This was stop-gap until dotnet-watch was updated to support MetadataUpdateHandlerAttribute
| using System.Linq; | ||
| using System.Reflection; | ||
|
|
||
| namespace Microsoft.Extensions.HotReload |
There was a problem hiding this comment.
Pretty identical to the code in https://raw.githubusercontent.com/dotnet/sdk/f67f46eba6d3bcf2b3054381851a975096652454/src/BuiltInTools/DotNetDeltaApplier/HotReloadAgent.cs. There's some usings that are different. Also it no longer supports the BeforeUpdate and AfterUpdate methods that dotnet-watch temporarily supports.
|
|
||
| static WebAssemblyHotReload() | ||
| private static HotReloadAgent? _hotReloadAgent; | ||
| private static UpdateDelta[] _updateDeltas = new[] |
There was a problem hiding this comment.
Why is this a list if we're ever only managing a single delta at a time?
There was a problem hiding this comment.
I wanted to keep the HotReloadAgent code identical. Right now, the blazor webassembly hot reload, sends deltas one at a time for "reasons" so using an array works. It would be worthwhile to switch it up and have it receive all of the deltas simultaneously, but that would be a little more effort to plumb thru. Another day!
ghost
added this to the
Contributes to dotnet/runtime#51545