Skip to content

Update build pipeline to publish source-build packages #33558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 15, 2021

Conversation

MichaelSimons
Copy link
Member

@MichaelSimons MichaelSimons requested a review from JunTaoLuo June 15, 2021 18:42
@MichaelSimons MichaelSimons requested a review from a team as a code owner June 15, 2021 18:42
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jun 15, 2021
@@ -32,7 +32,8 @@
Condition=" '$(PublishInstallerBaseVersion)' == 'true' " />
<_InstallersToPublish Include="$(ArtifactsDir)installers\**\*.wixlib" UploadPathSegment="Runtime" />
<_InstallersToPublish Include="$(ArtifactsDir)installers\**\*.zip" UploadPathSegment="Runtime" />
<_ChecksumsToPublish Include="$(ArtifactsDir)**\*.sha512" />
<_ChecksumsToPublish Include="$(ArtifactsDir)packages\**\*.sha512" />
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't use $(ArtifactsDir)**\*.sha512 with source build as the inner clone gets searched and picks up the checksums of some packages that get restored.

Copy link
Contributor

@JunTaoLuo JunTaoLuo Jun 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI @dotnet/aspnet-build. I assume it's verified all our *.sha512 files are from installers and packages in both public and internal builds?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upon taking a second look. It not necessary to scan packages because we only generate checksums for items in installers - https://github.com/dotnet/aspnetcore/blob/main/eng/AfterSigning.targets#L21

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, just installers

Copy link
Contributor

@JunTaoLuo JunTaoLuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, assuming we've verified we aren't missing any existing .sha512 files that's currently included in publishing.

@MichaelSimons
Copy link
Member Author

Looks good, assuming we've verified we aren't missing any existing .sha512 files that's currently included in publishing.

I compared the test build against the most recent build of main and see the same checksum files being published to the BlobArtifacts folder.

@MichaelSimons MichaelSimons enabled auto-merge June 15, 2021 19:03
@MichaelSimons MichaelSimons disabled auto-merge June 15, 2021 19:09
@MichaelSimons MichaelSimons merged commit 3e3f51a into dotnet:main Jun 15, 2021
@ghost ghost added this to the 6.0-preview6 milestone Jun 15, 2021
@MichaelSimons MichaelSimons deleted the issue-33343 branch June 15, 2021 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Microsoft.SourceBuild.Intermediate NuGet package is not getting published in official CI
3 participants