-
Notifications
You must be signed in to change notification settings - Fork 10.4k
Update build pipeline to publish source-build packages #33558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
eng/Publishing.props
Outdated
@@ -32,7 +32,8 @@ | |||
Condition=" '$(PublishInstallerBaseVersion)' == 'true' " /> | |||
<_InstallersToPublish Include="$(ArtifactsDir)installers\**\*.wixlib" UploadPathSegment="Runtime" /> | |||
<_InstallersToPublish Include="$(ArtifactsDir)installers\**\*.zip" UploadPathSegment="Runtime" /> | |||
<_ChecksumsToPublish Include="$(ArtifactsDir)**\*.sha512" /> | |||
<_ChecksumsToPublish Include="$(ArtifactsDir)packages\**\*.sha512" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't use $(ArtifactsDir)**\*.sha512
with source build as the inner clone gets searched and picks up the checksums of some packages that get restored.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI @dotnet/aspnet-build. I assume it's verified all our *.sha512 files are from installers and packages in both public and internal builds?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upon taking a second look. It not necessary to scan packages because we only generate checksums for items in installers - https://github.com/dotnet/aspnetcore/blob/main/eng/AfterSigning.targets#L21
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, just installers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, assuming we've verified we aren't missing any existing .sha512 files that's currently included in publishing.
I compared the test build against the most recent build of main and see the same checksum files being published to the |
Fixes #33343
Here is a test build (internal link): https://dnceng.visualstudio.com/internal/_build/results?buildId=1188339&view=results