Streaming CI Debugging #33917
Merged
Streaming CI Debugging #33917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
| // Act & Assert 1 | ||
| // Wait past the initial timeout + 15 sec buffer room and then | ||
| // confirm unhandled exception raised to crush circuit | ||
| await Task.Delay(TimeSpan.FromSeconds(25)); |
There was a problem hiding this comment.
Tests should be rewritten to not rely on Task.Delay.
|
Passes CI, merging into https://github.com/dotnet/aspnetcore/tree/taparik/streamingFollowups |
TanayParikh
added a commit
that referenced
this pull request
Jul 9, 2021
* Streaming Interop Followup Items * Streaming CI Debugging (#33917) * CI Debugging * CiData message * CiData message * Update RemoteJSDataStream.cs * Remove Task.Delay * Update RemoteJSDataStream.cs * Update RemoteJSDataStream.cs * PR Feedback (Including PipeReader Property) * Improve documentation on safe defaults * Task Completion Source & DefaultTimeout * InvalidateLastDataReceivedTimeForTimeout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<Ignore this, just using it to debug tests failing only in CI>