Skip to content

Set DisplayName on ActionDescriptor #34063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

martincostello
Copy link
Member

@martincostello martincostello commented Jul 3, 2021

PR Title

Fix ActionDescriptor.DisplayName always being null with minimal actions.

PR Description

Copy the DisplayName from the route endpoint to the ActionDescriptor.

Fixes #34062.

Copy the DisplayName from the route endpoint to the ActionDescriptor.
Addresses dotnet#34062.
@ghost ghost added area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates community-contribution Indicates that the PR has been added by a community member labels Jul 3, 2021
martincostello added a commit to martincostello/aspnetcore that referenced this pull request Jul 3, 2021
Applies a number of Visual Studio suggestions and errors found while
working on dotnet#34063.
@pranavkm pranavkm merged commit 49042d1 into dotnet:main Jul 3, 2021
@ghost ghost added this to the 6.0-preview7 milestone Jul 3, 2021
pranavkm pushed a commit that referenced this pull request Jul 3, 2021
Applies a number of Visual Studio suggestions and errors found while
working on #34063.
@martincostello martincostello deleted the Fix-Missing-ApiDescription-Props-34062 branch July 3, 2021 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WithDisplayName() on endpoint not working with ApiDescription with minimal actions
2 participants