[SignalR TS] Ignore user errors from stream callbacks #34136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrennanConroy
added
area-signalr
BrennanConroy
changed the title
halter73
reviewed
Jul 8, 2021
| try { | ||
| callback(message); | ||
| } catch (e) { | ||
| this._logger.log(LogLevel.Error, `Stream callback threw error '${e}'.`); |
There was a problem hiding this comment.
Suggested change
| this._logger.log(LogLevel.Error, `Stream callback threw error '${e}'.`); | |
| this._logger.log(LogLevel.Error, `Stream callback threw error '${e.stack}'.`); |
I think we should probably audit the other places we log errors for this.
halter73
approved these changes
Jul 9, 2021
ghost
added this to the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do the same thing for
.onand.onclose