Run blazor create/build/publish as part of template tests #34275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-mvc
|
Create/build/publish tests are added back to ProjectTemplates, these tests are currently not running on helix again due to the last runtime dependency update, so you can see the new tests running in the Wdinws_testTempates_Results:
|
pranavkm
reviewed
Jul 12, 2021
| } | ||
|
|
||
| var appSettings = ReadFile(serverProject.TemplateOutputDir, "appsettings.json"); | ||
| var element = JsonSerializer.Deserialize<JsonElement>(appSettings); |
There was a problem hiding this comment.
Any chance you could only use STJ? Most of the things this is doing should be achievable using a JsonDocument or using an actual type.
There was a problem hiding this comment.
I just lifted this from the existing template tests, do you want me to file a cleanup issue to switching both of these?
pranavkm
approved these changes
Jul 12, 2021
This was referenced Jul 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.