Add support for TryParse(HttpContext, ...) to RequestDelegateFactory #35433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halter73
requested review from
BrennanConroy,
javiercn,
Pilchie,
pranavkm and
Tratcher
as code owners
davidfowl
reviewed
Aug 18, 2021
| @@ -56,8 +59,9 @@ public static partial class RequestDelegateFactory | |||
| private static readonly MemberExpression StatusCodeExpr = Expression.Property(HttpResponseExpr, typeof(HttpResponse).GetProperty(nameof(HttpResponse.StatusCode))!); | |||
| private static readonly MemberExpression CompletedTaskExpr = Expression.Property(null, (PropertyInfo)GetMemberInfo<Func<Task>>(() => Task.CompletedTask)); | |||
|
|
|||
| private static readonly BinaryExpression TempSourceStringNotNullExpr = Expression.NotEqual(TryParseMethodCache.TempSourceStringExpr, Expression.Constant(null)); | |||
| private static readonly BinaryExpression TempSourceStringNullExpr = Expression.Equal(TryParseMethodCache.TempSourceStringExpr, Expression.Constant(null)); | |||
| private static ParameterExpression TempSourceStringExpr => TryParseMethodCache.TempSourceStringExpr; | |||
ghost
added this to the
|
Wrong branch @halter73? Or rather, we should also merge this into the release/6.0.0-rc1 branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TryParse(HttpContext, ...)is preferred overTryParse(string, ...)if both are present.TryParse(HttpContext, ...)will never be used if the parameter is a nullable struct, but it could fall back toTryParse(string, ...)in this case