Allow explicit manual runs of mirror pipeline #41736
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-infrastructure
wtgodbe
commented
May 18, 2022
dougbu
reviewed
May 18, 2022
| # Run the pipeline manually (usually disallowed) | ||
| - name: manualRun | ||
| default: false | ||
| displayName: Are you sure you want to run this pipeline manually? |
There was a problem hiding this comment.
Could you explain the point of this confirmation❔
There was a problem hiding this comment.
The use case of this pipeline is pretty narrow, and given that we're making users explicitly opt-in to running it manually, I think it makes sense to ask for confirmation.
dougbu
approved these changes
May 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case we ever need to trigger this manually, surface a checkbox to the user. Test build worked (though couldn't actually do any mirroring, since the variable group we use is only available on branches named
main)