Add [RequiresUnreferencedCode] attribute to top level APIs. #47663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchdenny
requested review from
BrennanConroy,
halter73,
Tratcher and
a team
as code owners
ghost
added
the
needs-area-label
BrennanConroy
approved these changes
Apr 12, 2023
danmoseley
reviewed
Apr 12, 2023
src/Mvc/Mvc.RazorPages/src/DependencyInjection/MvcRazorPagesMvcCoreBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
|
@mitchdenny is it possible to get a screenshot of this lighting up in VS on a new native AOT project? |
captainsafia
approved these changes
Apr 13, 2023
Yeah good call, I hadn't actually noticed them. I've reverted them in the latest commit. I did trigger a build of blazor as I was testing some of my changes, but I'm not gonna try and parse what is different in that minified mess ;) |
github-actions
bot
added
area-mvc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #47521
Had to pick up a few other top level APIs in addition to the ones referenced. Did not annotate request localization because testing showed it seemed to be working.