-
Notifications
You must be signed in to change notification settings - Fork 10.4k
Add debug output to HttpContext and friends #48293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Something we should consider is the formatting of properties and values. Existing debugger display attributes tend to use the format Idea: We stick with our format |
I switched to using I want things to easily fit into the debug window, and most of these fields seem obvious from context. The expanded view breaks down the individual fields. |
Contributes to #48205
I've added debug views to HttpContext and related types. While some of the views appear to be pass through, they actually work to hide internal implementation details from the underlying types. Note we can't put debug views on interfaces so I had to do it directly on implementing types. IIS and HttpSys share a header collection implementation.
The ToString implementations are optional, we could make those private
string CreateDebugView()
instead.Other properties to consider: