Skip to content

Remove Blazor Server template #48615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 21, 2023

Conversation

surayya-MS
Copy link
Member

Remove Blazor Server template

Part of #48341

@surayya-MS surayya-MS requested a review from a team as a code owner June 5, 2023 11:17
@ghost ghost added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Jun 5, 2023
Copy link
Member

@javiercn javiercn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@SteveSandersonMS @danroth27 any thoughts before we merge?

We should coordinate this removal with lighting up the equivalent option using full stack Blazor.

@SteveSandersonMS
Copy link
Member

SteveSandersonMS commented Jun 5, 2023

Looks great to me too.

As for shipping this change in preview 6, where are we currently with the universal Blazor web template? Is that already sufficient to replace the Blazor Server template? Will people be able to File->New and pick some options in the wizard, then F5 to run without having to make various code edits to get Blazor Server-type functionality?

I think we would not want to have a preview release in which there isn't an easy way to create a Blazor Server project, as that's core to the product experience and the ability to try out preview features. As long as the universal template has already reached the stage that it's trivial to get a classic Blazor Server project out of it, then I think we're good. But if not then it might be premature to actually remove the old template from the SDK.

We should coordinate this removal with lighting up the equivalent option using full stack Blazor.

Update: Yes, looks like that sentence was added afterwards, and confirms we're thinking on the same lines.

@ghost
Copy link

ghost commented Jun 15, 2023

Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime.
To make sure no breaking changes are introduced, please leave an /azp run comment here to rerun the CI pipeline and confirm success before merging the change.

@ghost ghost added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Jun 15, 2023
@surayya-MS surayya-MS merged commit fe89ccf into dotnet:main Jun 21, 2023
@surayya-MS surayya-MS deleted the removeBlazorServerTemplate branch June 21, 2023 19:28
@ghost ghost added this to the 8.0-preview6 milestone Jun 21, 2023
marcpopMSFT added a commit to dotnet/installer that referenced this pull request Jun 22, 2023
marcpopMSFT added a commit to dotnet/installer that referenced this pull request Jun 23, 2023
omajid added a commit to omajid/dotnet-regular-tests that referenced this pull request Jul 13, 2023
The blazorserver and blazorserver-empty templates have been removed from
Preview 6. Upstream PR: dotnet/aspnetcore#48615.
Update tests to work correctly against that.
omajid added a commit to redhat-developer/dotnet-regular-tests that referenced this pull request Jul 13, 2023
The blazorserver and blazorserver-empty templates have been removed from
Preview 6. Upstream PR: dotnet/aspnetcore#48615.
Update tests to work correctly against that.
nicolestandifer3 added a commit to nicolestandifer3/regular-tests-dotnet that referenced this pull request Aug 6, 2023
The blazorserver and blazorserver-empty templates have been removed from
Preview 6. Upstream PR: dotnet/aspnetcore#48615.
Update tests to work correctly against that.
ViktorHofer pushed a commit to dotnet/sdk that referenced this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants