[skip-ci] Add missing xml docs for ExceptionHandler #48814
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
area-runtime
community-contribution
|
Thanks for your PR, @divyeshio. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
amcasey
approved these changes
Jun 14, 2023
amcasey
added
area-middleware
| /// | ||
| /// Represents an interface for handling exceptions in ASP.NET Core applications. | ||
| /// Implementations of this interface can provide custom exception handling logic for | ||
| /// different scenarios in the application. | ||
| /// </summary> | ||
| public interface IExceptionHandler |
There was a problem hiding this comment.
TryHandleAsync below also needs to be filled in.
There was a problem hiding this comment.
Other than that, this looks good to me. Thanks for doing it.
JamesNK
previously requested changes
Jun 15, 2023
src/Middleware/Diagnostics/src/ExceptionHandler/ExceptionHandlerServiceCollectionExtensions.cs
Outdated
Show resolved
Hide resolved
src/Middleware/Diagnostics/src/ExceptionHandler/IExceptionHandler.cs
Outdated
Show resolved
Hide resolved
…erServiceCollectionExtensions.cs Co-authored-by: James Newton-King <[email protected]>
…ler.cs Co-authored-by: James Newton-King <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds missing inline xml docs for IExceptionHandler and AddExceptionHandler method
Fixes #48640