Fix 48934 test quarantine. #48936
Merged
Fix 48934 test quarantine. #48936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
mitchdenny
force-pushed
the
fix-48934-test-quarantine
branch
from
793b265 to
2388875
Compare
JamesNK
reviewed
Jun 21, 2023
src/Middleware/WebSockets/test/UnitTests/WebSocketMiddlewareTests.cs
Outdated
Show resolved
Hide resolved
JamesNK
reviewed
Jun 21, 2023
mitchdenny
force-pushed
the
fix-48934-test-quarantine
branch
from
2388875 to
590f70b
Compare
JamesNK
approved these changes
Jun 22, 2023
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the reason why we had to quarantine the
WebSocket_Abort_Interrupts_Pending_ReceiveAsynctest case in issue #48934The test in its original form was very timing sensitive in that if
WebSocket.Abort(...)was called beforeWebSocket.ReceiveAsync(...)the exception thrown would change.This change in the test case exerts more control over the exact sequence of events so that the call to
ReceiveAsync(...)is made beforeWebSocket.Abort(...)is called so we are not subject to timing issues.