Give error if the root component is interactive. Fixes #48847 #48945
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -19,7 +19,6 @@ internal class RazorComponentEndpointHost : IComponent | |||
| { | |||
| private RenderHandle _renderHandle; | |||
|
|
|||
| [Parameter] public IComponentRenderMode? RenderMode { get; set; } | |||
There was a problem hiding this comment.
Cleaning up unused code. It's an internal component and we never supplied a value for this parameter, nor would it ever make sense for us to do so.
javiercn
approved these changes
Jun 21, 2023
SteveSandersonMS
force-pushed
the
stevesa/error-if-root-component-is-interactive
branch
from
317b67e to
87d646a
Compare
SteveSandersonMS
deleted the
stevesa/error-if-root-component-is-interactive
branch
ghost
added this to the
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For reasoning, see #48793 (comment)
Since this is purely a client-side error (and it would already have been an error before; this just changes the error text that comes out) I'm not prioritizing adding an explicit E2E test for it.