Skip to content

Implement ITlsHandshakeFeature in IIS #48957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 26, 2023
Merged

Implement ITlsHandshakeFeature in IIS #48957

merged 5 commits into from
Jun 26, 2023

Conversation

karimsalem1
Copy link
Contributor

@karimsalem1 karimsalem1 commented Jun 22, 2023 •
edited by Tratcher
Loading

Implement ITlsHandshakeFeature in IIS

Implementing ITlsHandshakeFeature to expose TLS details in IIS server, including the new Hostname API.

Issue opened and API approved here: Fixes #34525

Description

This PR:

  • Implements ITlsHandshakeFeature in IISHttpContext
  • Refactors common code for setting SslProtocol in IIS and Http.sys
  • Extends TestServer to accept HTTPS connections

@ghost ghost added area-runtime community-contribution Indicates that the PR has been added by a community member labels Jun 22, 2023
@ghost
Copy link

ghost commented Jun 22, 2023

Thanks for your PR, @karimsalem1. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@karimsalem1 karimsalem1 changed the title initial commit Implement ITlsHandshakeFeature in IIS Jun 22, 2023
@karimsalem1 karimsalem1 marked this pull request as ready for review June 22, 2023 15:13
Tratcher
Tratcher reviewed Jun 23, 2023
View reviewed changes
Tratcher
Tratcher reviewed Jun 23, 2023
View reviewed changes
@Tratcher Tratcher enabled auto-merge (squash) June 23, 2023 23:40
@Tratcher
Copy link
Member

Thanks!

@Tratcher Tratcher added this to the 8.0-preview7 milestone Jun 23, 2023
@adityamandaleeka adityamandaleeka mentioned this pull request Jun 26, 2023
Open
@adityamandaleeka
Copy link
Member

CI failure is unrelated. Opened an issue for that and re-ran the leg: #49035

@Tratcher Tratcher merged commit a31d83b into dotnet:main Jun 26, 2023
@adityamandaleeka
Copy link
Member

Thanks @karimsalem1

@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tratcher Tratcher Tratcher approved these changes

@halter73 halter73 Awaiting requested review from halter73 halter73 is a code owner

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy BrennanConroy is a code owner

@JamesNK JamesNK Awaiting requested review from JamesNK JamesNK is a code owner

@mgravell mgravell Awaiting requested review from mgravell mgravell is a code owner

Assignees

@adityamandaleeka adityamandaleeka

Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
8.0-preview7
Development

Successfully merging this pull request may close these issues.

Expose SNI hostname via a feature
4 participants
@karimsalem1 @Tratcher @adityamandaleeka @amcasey