Skip to content

Don't warn on app.UseEndpoints(e => {}); #48977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 23, 2023
Merged

Don't warn on app.UseEndpoints(e => {}); #48977

merged 3 commits into from
Jun 23, 2023

Conversation

BArthur1972
Copy link
Contributor

Description

Updated ASP0014 to only warn when there are actual invocations in the body of UseEndpoints() delegate.

Fixes #46270

@ghost ghost added area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates community-contribution Indicates that the PR has been added by a community member labels Jun 23, 2023
@ghost
Copy link

ghost commented Jun 23, 2023

Thanks for your PR, @BArthur1972. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

mitchdenny
mitchdenny approved these changes Jun 23, 2023
View reviewed changes
Copy link
Member

@mitchdenny mitchdenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

captainsafia
captainsafia approved these changes Jun 23, 2023
View reviewed changes
Copy link
Member

@captainsafia captainsafia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! A few comments inline.

@captainsafia captainsafia enabled auto-merge (squash) June 23, 2023 18:53
@captainsafia captainsafia merged commit 1a56bdb into dotnet:main Jun 23, 2023
@ghost ghost added this to the 8.0-preview7 milestone Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitchdenny mitchdenny mitchdenny approved these changes

@captainsafia captainsafia captainsafia approved these changes

Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
8.0-preview7
Development

Successfully merging this pull request may close these issues.

Don't warn on app.UseEndpoints(e => {}); in RouteHandlerAnalyzer
3 participants
@BArthur1972 @mitchdenny @captainsafia