Callsite rendermodes (#48967) #49055
Merged
+638
−60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* builder.AddComponentRenderMode API and storage on RenderTree * Extend ResolveComponentForRenderMode to receive callerSpecifiedRenderMode, and supply it from ComponentFactory * Simplify API: collapse the two rendermode sources into a single rendermode before calling ResolveComponentForRenderMode * Corresponding renames * Actually supply callsite rendermode from RenderTree * Give clearer errors if misusing this feature * Build fix * Actually use the parameter name @rendermode for forward-compatibility with the final syntax * Add E2E tests
ghost
added
the
surayya-MS
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a forward-port to
mainof #48967, which was already merged intorelease/8.0-preview6via ask mode.