Skip to content

Add public metadata types. #49068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jul 6, 2023
Merged

Add public metadata types. #49068

merged 10 commits into from
Jul 6, 2023

Conversation

mitchdenny
Copy link
Member

Implements #47994

@ghost ghost added the area-runtime label Jun 28, 2023
@mitchdenny mitchdenny marked this pull request as draft June 28, 2023 07:59
@mitchdenny
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@mitchdenny mitchdenny marked this pull request as ready for review July 3, 2023 14:41
@mitchdenny mitchdenny requested a review from brunolins16 as a code owner July 3, 2023 14:41
@mitchdenny
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

captainsafia
captainsafia approved these changes Jul 5, 2023
View reviewed changes
Copy link
Member

@captainsafia captainsafia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a note on the submodule changes and a note on XML docs.

@mitchdenny mitchdenny force-pushed the public-metadata-types branch from 0089e25 to 37d7d3c Compare July 6, 2023 04:39
@mitchdenny mitchdenny merged commit 489de75 into dotnet:main Jul 6, 2023
@ghost ghost added this to the 8.0-preview7 milestone Jul 6, 2023
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@captainsafia captainsafia captainsafia approved these changes

@wtgodbe wtgodbe Awaiting requested review from wtgodbe

@javiercn javiercn Awaiting requested review from javiercn

@Tratcher Tratcher Awaiting requested review from Tratcher

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy BrennanConroy is a code owner

@halter73 halter73 Awaiting requested review from halter73 halter73 is a code owner

@brunolins16 brunolins16 Awaiting requested review from brunolins16

Assignees
No one assigned
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Projects
None yet
Milestone
8.0-preview7
Development

Successfully merging this pull request may close these issues.
3 participants
@mitchdenny @captainsafia @amcasey