Fix invalid catch block in StringUtilities #49082
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Erk, that commit contains a syntax error and wasn't supposed to go through as-is. Let me fix it. |
adityamandaleeka
approved these changes
Jun 28, 2023
danmoseley
reviewed
Jun 29, 2023
| @@ -683,9 +683,13 @@ private static bool IsValidHeaderString(string value) | |||
| new UTF8Encoding(encoderShouldEmitUTF8Identifier: false, throwOnInvalidBytes: true).GetByteCount(value); | |||
| return !value.Contains('\0'); | |||
| } | |||
| catch (DecoderFallbackException) | |||
| catch (ArgumentOutOfRangeException) | |||
There was a problem hiding this comment.
method itself should probably be [Conditional("DEBUG")]
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method
Encoding.GetByteCountwill never throwDecoderFallbackException. Instead, the two exceptions it can throw which are relevant here are:ArgumentOutOfRangeException, when the input is so large that it the UTF-8 byte count can't be represented in a 32-bit integer; andEncoderFallbackException, when the input is not valid UTF-16.This PR corrects the catch block to detect these two exceptional cases.