-
Notifications
You must be signed in to change notification settings - Fork 10.4k
Revert "[main] Update dependencies from dotnet/runtime" #49113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "[main] Update dependencies from dotnet/runtime" #49113
Conversation
This reverts commit d07f4d4.
What's the actual policy around components-e2e? It's not considered required because it's too flaky. But then why would we revert for a failure in a non-required pipeline? What prevents this from happening again tomorrow? |
@Tratcher I don't think that's the case. We've done a bunch of work on stability with retries and it has been stable for quite a while, @SteveSandersonMS do you know if/why this is not required? |
@javiercn is right - I don't think the components E2E tests have been flaky for about 2 years. I thought they were now required, but I could be wrong about that. A few of them are quarantined but the nonquarantined ones are not expected to be flaky.
If the change is deterministically causing failure, or is noticeably increasing failure, then that seems like strong evidence that it's breaking a shipping, supported part of our product. I'd expect us not to want to do that 😄 |
Given there are only 6 tests affected and we understand the issue, we should skip those tests rather than reverting the runtime. Rolling back and pausing runtime updates affects other workflows and means we don't find other breaks in a timely manner. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue is resolved. Next flow from runtime should fix components-e2e tests |
Pull request was closed
Reverts #49075
This is breaking the blazor E2E tests. Filed issue to track dotnet/runtime#88250