Skip to content

Revert "[main] Update dependencies from dotnet/runtime" #49113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

javiercn
Copy link
Member

Reverts #49075

This is breaking the blazor E2E tests. Filed issue to track dotnet/runtime#88250

@ghost ghost added the area-runtime label Jun 30, 2023
@javiercn javiercn marked this pull request as ready for review June 30, 2023 14:36
@Tratcher
Copy link
Member

Tratcher commented Jun 30, 2023

What's the actual policy around components-e2e? It's not considered required because it's too flaky. But then why would we revert for a failure in a non-required pipeline? What prevents this from happening again tomorrow?

@javiercn
Copy link
Member Author

@Tratcher I don't think that's the case.

We've done a bunch of work on stability with retries and it has been stable for quite a while, @SteveSandersonMS do you know if/why this is not required?

@SteveSandersonMS
Copy link
Member

@javiercn is right - I don't think the components E2E tests have been flaky for about 2 years. I thought they were now required, but I could be wrong about that. A few of them are quarantined but the nonquarantined ones are not expected to be flaky.

But then why would we revert for a failure in a non-required pipeline?

If the change is deterministically causing failure, or is noticeably increasing failure, then that seems like strong evidence that it's breaking a shipping, supported part of our product. I'd expect us not to want to do that 😄

@Tratcher
Copy link
Member

Given there are only 6 tests affected and we understand the issue, we should skip those tests rather than reverting the runtime. Rolling back and pausing runtime updates affects other workflows and means we don't find other breaks in a timely manner.

Copy link
Member

@Tratcher Tratcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest skipping the affected tests instead. #49127 #49109

@maraf
Copy link
Member

maraf commented Jun 30, 2023

The issue is resolved. Next flow from runtime should fix components-e2e tests

This was referenced Jun 30, 2023
@javiercn javiercn closed this Jul 3, 2023
auto-merge was automatically disabled July 3, 2023 09:41

Pull request was closed

@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Aug 25, 2023
@javiercn javiercn deleted the revert-49075-darc-main-486f9ac2-8f16-4224-9ecb-8a01883d73c3 branch November 12, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants