Skip to content

Fix Http MinimalSample #49174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 6, 2023
Merged

Fix Http MinimalSample #49174

merged 3 commits into from
Jul 6, 2023

Conversation

xakep139
Copy link
Contributor

@xakep139 xakep139 commented Jul 3, 2023 •
edited
Loading

Fix CA1837 in Http MinimalSample

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Description

Fixes an issue in HTTP MinimalSample, as per https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1837 Environment.ProcessId should be used instead of Process.GetCurrentProcess().Id

@ghost ghost added the area-runtime label Jul 3, 2023
@xakep139 xakep139 mentioned this pull request Jul 3, 2023
Merged
@JamesNK JamesNK enabled auto-merge (squash) July 3, 2023 12:38
@xakep139 xakep139 self-assigned this Jul 3, 2023
@xakep139
Copy link
Contributor Author

xakep139 commented Jul 3, 2023

e2e test failures seem unrelated to the PR

@mitchdenny
Copy link
Member

They are not related. We are currently blocked on a runtime fix.

@xakep139 xakep139 requested a review from a team as a code owner July 3, 2023 16:34
@captainsafia
Copy link
Member

@dotnet/aspnet-build Can we get help merging this without having to rerun the components-e2e task?

@wtgodbe wtgodbe disabled auto-merge July 6, 2023 18:36
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jul 6, 2023
@wtgodbe wtgodbe merged commit 96ba5bd into dotnet:main Jul 6, 2023
@ghost ghost added this to the 8.0-preview7 milestone Jul 6, 2023
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesNK JamesNK JamesNK approved these changes

@Tratcher Tratcher Awaiting requested review from Tratcher

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy BrennanConroy is a code owner

@halter73 halter73 Awaiting requested review from halter73 halter73 is a code owner

@captainsafia captainsafia Awaiting requested review from captainsafia captainsafia is a code owner

Assignees

@xakep139 xakep139

Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Projects
None yet
Milestone
8.0-preview7
Development

Successfully merging this pull request may close these issues.
6 participants
@xakep139 @mitchdenny @captainsafia @JamesNK @amcasey @wtgodbe