Remove stack overflow in EndpointFilterInvocationContexts

[slang25]

Remove potential stack overflow in EndpointFilterInvocationContexts

• You've read the Contributor Guide and Code of Conduct.
• You've included unit or integration tests for your change, where applicable.
• You've included inline docs for your change, where applicable.
• There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Description

This change replaces the infinite recursive behaviour of the properties on the EndpointFilterInvocationContext types, and implement the Contains and IndexOf method explicitly instead.

Fixes #49284

[ghost]

Thanks for your PR, @slang25. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

[davidfowl]

Why not implement these instead?

[slang25]

Why not implement these instead?

Good point, I've just pushed an implementation 👍

[adityamandaleeka]

@slang25 There's a whitespace mismatch that's causing a test to fail. Looks like you cleaned up some stray spaces on an empty line which it's not happy about 😆.

 Microsoft.AspNetCore.Http.Abstractions.Tests.EndpointFilterInvocationContextOfTTests.GeneratedCodeIsUpToDate [FAIL]
2023-07-10T10:14:57.7566156Z [xUnit.net 00:00:05.90]       Assert.Equal() Failure
2023-07-10T10:14:57.7592174Z [xUnit.net 00:00:05.90]                                          ↓ (pos 1189)
2023-07-10T10:14:57.7618665Z [xUnit.net 00:00:05.91]       Expected: ···Arg0 { get; set; }\r\n\r\n    public int Count => 1;\r\n\r\n    publi···
2023-07-10T10:14:57.7645943Z [xUnit.net 00:00:05.91]       Actual:   ···Arg0 { get; set; }\r\n    \r\n    public int Count => 1;\r\n\r\n    p···
2023-07-10T10:14:57.7673019Z [xUnit.net 00:00:05.91]                                          ↑ (pos 1189)
2023-07-10T10:14:57.7704214Z [xUnit.net 00:00:05.92]       Stack Trace:
2023-07-10T10:14:57.7735788Z [xUnit.net 00:00:05.92]         /_/src/Http/Http.Abstractions/test/EndpointFilterInvocationContextOfTTests.cs(96,0): at Microsoft.AspNetCore.Http.Abstractions.Tests.EndpointFilterInvocationContextOfTTests.GeneratedCodeIsUpToDate()

[slang25]

Just to explain this change, I'm on macOS and using either Rider or VSCode the editors immediately delete the whitespace from the generated files the moment I touch them, so this change makes editing them by hand less volatile.

Why am I editing the generated code by hand? Because when I try to use the tt generator it completely re-writes the file in a way that creates a massive diff (the header text is different for example).

[martincostello]

Might be worth at some point having the repo updated to use the .NET 6 version of the tt generator - maybe that'll remove some of the xplat wonk (after an initial normalisation).

[captainsafia]

Good recommendation! Mind filing an issue for this in case we're able to get around to it?

[martincostello]

#49382

[slang25]

Thanks for your help @adityamandaleeka, I totally missed that.

[ghost]

Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime.
To make sure no conflicting changes have occurred, please rerun validation before merging. You can do this by leaving an /azp run comment here (requires commit rights), or by simply closing and reopening.

[slang25]

/azp run

[azure-pipelines]

Commenter does not have sufficient privileges for PR 49285 in repo dotnet/aspnetcore

[slang25]

close & open to trigger to re-run validation

[captainsafia]

/azp run

[azure-pipelines]

No commit pushedDate could be found for PR 49285 in repo dotnet/aspnetcore