Skip to content

Revert "[main] Update dependencies from dotnet/arcade" #49520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented Jul 19, 2023

Breaks local builds: dotnet/arcade#13911

@wtgodbe wtgodbe requested a review from a team as a code owner July 19, 2023 17:32
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jul 19, 2023
@wtgodbe wtgodbe enabled auto-merge (squash) July 19, 2023 17:33
@adityamandaleeka
Copy link
Member

@wtgodbe Do we have any CI jobs failing with this build break? Looks like none of the PR jobs actually build these IIS tests so it's a blindspot in coverage.

@wtgodbe
Copy link
Member Author

wtgodbe commented Jul 19, 2023

I think the Helix job builds them:

- script: ./eng/build.cmd -ci -nobl -all -pack -arch x64
/p:CrossgenOutput=false /p:ASPNETCORE_TEST_LOG_DIR=artifacts/log $(_InternalRuntimeDownloadArgs)

@adityamandaleeka
Copy link
Member

Uh, looks like -ci makes it pass. 😖

@wtgodbe
Copy link
Member Author

wtgodbe commented Jul 19, 2023

Uh, looks like -ci makes it pass. 😖

Weird - at least that's a datapoint 😆. I mentioned that in the Arcade issue. Could you approve this PR?

@wtgodbe wtgodbe merged commit 2ab4088 into main Jul 19, 2023
@wtgodbe wtgodbe deleted the revert-49463-darc-main-698bb766-1a3a-45a7-9f06-4d5cc203f05a branch July 19, 2023 22:17
@ghost ghost added this to the 8.0-rc1 milestone Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants