Skip to content

Update _LoginPartial.Identity.cshtml with correct returnUrl #49553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 28, 2023
Merged

Update _LoginPartial.Identity.cshtml with correct returnUrl #49553

merged 2 commits into from
Jul 28, 2023

Conversation

danroth27
Copy link
Member

The logout form in the login partial for the Razor Pages template seems to have an incorrect returnUrl. Currently, the returnUrl parameter simply doesn't get generated, so when you logout you end up on the /Account/Logout page. I believe the intent is to be redirected back to the home page of the app.

@ghost ghost added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Jul 20, 2023
mkArtakMSFT
mkArtakMSFT approved these changes Jul 20, 2023
View reviewed changes
Copy link
Contributor

@mkArtakMSFT mkArtakMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @danroth27 !

@mkArtakMSFT mkArtakMSFT added area-ui-rendering Includes: MVC Views/Pages, Razor Views/Pages and removed area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates labels Jul 20, 2023
@ghost
Copy link

ghost commented Jul 28, 2023

Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime.
To make sure no conflicting changes have occurred, please rerun validation before merging. You can do this by leaving an /azp run comment here (requires commit rights), or by simply closing and reopening.

@ghost ghost added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Jul 28, 2023
@danroth27 danroth27 merged commit 6e3fe7c into main Jul 28, 2023
@danroth27 danroth27 deleted the danroth27/returnUrl branch July 28, 2023 16:16
@ghost ghost added this to the 8.0-rc1 milestone Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkArtakMSFT mkArtakMSFT mkArtakMSFT approved these changes

@halter73 halter73 Awaiting requested review from halter73

@JeremyLikness JeremyLikness Awaiting requested review from JeremyLikness

Assignees
No one assigned
Labels
area-ui-rendering Includes: MVC Views/Pages, Razor Views/Pages pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun
Projects
None yet
Milestone
8.0-rc1
Development

Successfully merging this pull request may close these issues.
2 participants
@danroth27 @mkArtakMSFT