Fix BindAsync and misc bugs in RDG #49693
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
old-area-web-frameworks-do-not-use
captainsafia
added
feature-rdg
area-minimal
captainsafia
requested review from
Tratcher,
BrennanConroy and
halter73
as code owners
| EndpointParameterSource.BindAsync => endpointParameter.IsOptional ? | ||
| endpointParameter.EmitHandlerArgument() : | ||
| endpointParameter.Type.IsValueType && endpointParameter.GetBindAsyncReturnType()?.OriginalDefinition.SpecialType == SpecialType.System_Nullable_T | ||
| ? $"{endpointParameter.EmitHandlerArgument()}.Value" |
There was a problem hiding this comment.
Should this be guarded? A user could write return null!; and then get an InvalidOperationException in our code.
There was a problem hiding this comment.
Good spot! I fixed this bug for RDG and added a test (MapAction_BindAsync_NullableReturn).
Turns out the same bug for structs exists in RDF. I haven't fixed it here but I've filed #49730 to track it.
src/Http/Http.Extensions/gen/StaticRouteHandlerModel/StaticRouteHandlerModel.Emitter.cs
Show resolved
Hide resolved
...xtensions/test/RequestDelegateGenerator/Baselines/MapAction_BindAsync_Snapshot.generated.txt
Outdated
Show resolved
Hide resolved
...xtensions/test/RequestDelegateGenerator/Baselines/MapAction_BindAsync_Snapshot.generated.txt
Outdated
Show resolved
Hide resolved
captainsafia
force-pushed
the
safia/minapi-playground-bug-fixes
branch
from
b161f5e to
69dae0a
Compare
captainsafia
force-pushed
the
safia/minapi-playground-bug-fixes
branch
from
69dae0a to
fa6c6d6
Compare
| codeWriter.WriteLine($"if ((object?){endpointParameter.EmitTempArgument()} == null)"); | ||
| codeWriter.WriteLine(endpointParameter.Type.IsValueType && endpointParameter.GetBindAsyncReturnType().IsNullableOfT() | ||
| ? $"if (!{endpointParameter.EmitHandlerArgument()}.HasValue)" | ||
| : $"if ({endpointParameter.EmitHandlerArgument()} == null)"); |
There was a problem hiding this comment.
if (ValueType == null) will result in a warning
There was a problem hiding this comment.
endpointParameter.GetBindAsyncReturnType().IsNullableOfT()
GetBindAsyncReturnType can return null, why isn't the compiler complaining?
There was a problem hiding this comment.
GetBindAsyncReturnType can return null, why isn't the compiler complaining?
IsNullableOfT takes a ITypeSymbol? and does a null safety check in its implementation.
| @@ -643,8 +609,7 @@ namespace Microsoft.AspNetCore.Http.Generated | |||
| async Task RequestHandler(HttpContext httpContext) | |||
| { | |||
| var wasParamCheckFailure = false; | |||
| var myBindAsyncParam_temp = await global::Microsoft.AspNetCore.Http.Generators.Tests.MyNullableBindAsyncStruct.BindAsync(httpContext, parameters[0]); | |||
| var myBindAsyncParam_local = (global::Microsoft.AspNetCore.Http.Generators.Tests.MyNullableBindAsyncStruct?)myBindAsyncParam_temp; | |||
| var myBindAsyncParam_local = await global::Microsoft.AspNetCore.Http.Generators.Tests.MyNullableBindAsyncStruct.BindAsync(httpContext, parameters[0]); | |||
|
|
|||
| if (wasParamCheckFailure) | |||
There was a problem hiding this comment.
nit: Unused code. Looks like it was here before the PR though.
BrennanConroy
approved these changes
Jul 31, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ErrortoWarningfor fallback scenariosEndpointParameterMetadataProviderwas not respected if parameters that didn't implement the interface existed on an endpointBindAsynchandling to resolve RDG doesn't supportBindAsyncresult with differing nullability #47199