Skip to content

[RDG] Fix mismatched nullability for structs and HTTP method whitespace #49805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

captainsafia
Copy link
Member

  • Add test and code changes for mismatched nullability with struct types
  • Fix indentation on generated HTTP methods

@ghost ghost added the area-runtime label Aug 2, 2023
@captainsafia captainsafia requested a review from mitchdenny August 2, 2023 17:25
@captainsafia captainsafia added feature-rdg area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc and removed area-runtime labels Aug 2, 2023
Copy link
Member

@mitchdenny mitchdenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@captainsafia captainsafia merged commit c6cc85c into main Aug 3, 2023
@captainsafia captainsafia deleted the safia/rdg-bug-fixes branch August 3, 2023 15:03
@ghost ghost added this to the 8.0-rc1 milestone Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc feature-rdg
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants