Quarantine CanRenderLargeComponentsWithServerRenderMode #49976
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
@captainsafia @MackinnonBuck Does this bring the new product code's correctness into question, or is there a known reason for the test to fail that is separate from the product implementation? |
|
@SteveSandersonMS I haven't been able to reproduce the issue locally, but my guess is that the prerendered output is getting replaced with non-prerendered output in between the call to |
|
I wonder if it would be satisfactory to have the test render non-interactive components since we're specifically testing SSR functionality anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.