[RDG] Account of parameter name in signature comparison #50064
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
captainsafia
requested review from
Tratcher,
BrennanConroy and
halter73
as code owners
ghost
added
the
captainsafia
commented
Aug 14, 2023
| @@ -162,7 +162,7 @@ namespace Microsoft.AspNetCore.Http.Generated | |||
| createRequestDelegate); | |||
| } | |||
|
|
|||
| [InterceptsLocation(@"TestMapActions.cs", 27, 5)] | |||
| [InterceptsLocation(@"TestMapActions.cs", 26, 5)] | |||
There was a problem hiding this comment.
This changed because we removed the #pragma disable line preceding this invocation.
captainsafia
commented
Aug 14, 2023
| @@ -172,6 +168,346 @@ namespace Microsoft.AspNetCore.Http.Generated | |||
| createRequestDelegate); | |||
| } | |||
|
|
|||
| [InterceptsLocation(@"TestMapActions.cs", 26, 5)] | |||
| internal static RouteHandlerBuilder MapGet1( | |||
There was a problem hiding this comment.
Each of these handlers has the same signature but different parameter sources and names and now generates different interceptor methods.
captainsafia
commented
Aug 14, 2023
| @@ -122,9 +122,7 @@ public async Task MapAction_ExplicitBodyParam_ComplexReturn_Snapshot() | |||
| }; | |||
| var source = $""" | |||
| app.MapPost("/fromBodyRequired", ([FromBody] Todo todo) => TypedResults.Ok(todo)); | |||
| #pragma warning disable CS8622 | |||
There was a problem hiding this comment.
Interceptors fixed generating overloads for methods with the same signature but differing nullability so we no longer have a warning to suppress.
src/Http/Http.Extensions/test/RequestDelegateGenerator/CompileTimeCreationTests.cs
Outdated
Show resolved
Hide resolved
…TimeCreationTests.cs Co-authored-by: Brennan <[email protected]>
BrennanConroy
approved these changes
Aug 14, 2023
amcasey
reviewed
Aug 14, 2023
src/Http/Http.Extensions/gen/StaticRouteHandlerModel/EndpointParameter.cs
Show resolved
Hide resolved
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #50048.