React to MapIdentityApi HTTP endpoints API review feedback #50067
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
persistCookies -> useSessionCookies
ghost
added
the
| @@ -90,12 +90,13 @@ public static IEndpointConventionBuilder MapIdentityApi<TUser>(this IEndpointRou | |||
| }); | |||
|
|
|||
| routeGroup.MapPost("/login", async Task<Results<Ok<AccessTokenResponse>, EmptyHttpResult, ProblemHttpResult>> | |||
| ([FromBody] LoginRequest login, [FromQuery] bool? cookieMode, [FromQuery] bool? persistCookies, [FromServices] IServiceProvider sp) => | |||
| ([FromBody] LoginRequest login, [FromQuery] bool? useCookies, [FromQuery] bool? useSessionCookies, [FromServices] IServiceProvider sp) => | |||
There was a problem hiding this comment.
Suggested change
| ([FromBody] LoginRequest login, [FromQuery] bool? useCookies, [FromQuery] bool? useSessionCookies, [FromServices] IServiceProvider sp) => | |
| ([FromBody] LoginRequest login, [FromQuery] bool? usePersistentCookies, [FromQuery] bool? useSessionCookies, [FromServices] IServiceProvider sp) => |
Was session deliberate?
There was a problem hiding this comment.
Was session deliberate?
It was. I'm going to send an email to update the API proposal. The reason is the default behavior prior to this change with just cookieMode=true was to presist cookies. persistCookies=false opted out of that, so persistCookies defaulted to true.
It was a horrible API, but making the simpler useCookies=true persist cookies by default still makes sense in my opinion.
BrennanConroy
approved these changes
Aug 14, 2023
Closed
1 task
There was a problem hiding this comment.
Is there any way to bring back snake_case?
Allowing to set casing would be ideal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #50009