Call AddMetrics inside AddRouting #50168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
sebastienros
approved these changes
Aug 17, 2023
Tratcher
approved these changes
Aug 17, 2023
JamesNK
commented
Aug 18, 2023
| var services = new ServiceCollection(); | ||
| services.AddLogging(); | ||
| services.AddOptions(); | ||
| services.AddSingleton<DiagnosticListener>(s => new DiagnosticListener("Test")); |
There was a problem hiding this comment.
@sebastienros UseRouting requires DiagnosticListener in DI, but I don't see that in OC source code. I'm confused how it worked before.
|
@Tratcher Multiple calls to AddMetrics has uncovered a problem with some changes you made to |
|
Blocked on dotnet/runtime#90779, which causes test failures in ASP.NET Core. We might struggle to get both fixes into rc1 on time. |
JamesNK
added
the
blocked
|
This PR doesn't seem critical for RC1, it's an uncommon issue with an easy workaround. I'll look into the other issue today. |
javiercn
approved these changes
Aug 22, 2023
javiercn
approved these changes
Aug 22, 2023
amcasey
added
area-networking
JamesNK
force-pushed
the
jamesnk/routing-addmetrics
branch
from
79ec039 to
ff64647
Compare
JamesNK
requested review from
halter73,
BrennanConroy,
mgravell,
a team,
captainsafia and
wtgodbe
as code owners
JamesNK
removed
the
blocked
joperezr
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Routing now uses metrics. The meter and counters are created using
IMeterFactory.IMeterFactoryis a new type and an implementation is registered by callingAddMetrics().AddMetrics()is called by host builders.However, this breaks if someone creates an app without using a host builder. They will get an error that
IMeterFactorycan't be resolved. Orchard Core doesn't use one of our built-in host builders and runs into this problem: https://github.com/OrchardCMS/OrchardCore/blob/fa03f92536de065c87f780ae27b277cce6d2d656/src/OrchardCore/OrchardCore/Modules/Extensions/ServiceCollectionExtensions.cs#L92. This is probably a rare situation.Fix this issue by calling
AddMetrics()insideAddRouting()so anIMeterFactoryis always present. If the host already added metrics then the extra add inside routing doesn't have any impact.