Rename area-runtime in fabricbot #50460
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-infrastructure
|
Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at. |
wtgodbe
approved these changes
Aug 31, 2023
|
Doing it manually is right |
|
dotnet-issue-labeler is the one that trains itself |
|
Interesting. This seems like it would be more reliable than the AI one. If we think this is sufficient, I believe we can opt out of automatic PR labelling, since the PR model is separate from the Issue model. |
amcasey
approved these changes
Aug 31, 2023
|
I think at the moment there are some things that the AI bot labels that aren't covered by fabricbot, and there's definitely functionality in fabricbot that isn't handled by the AI bot. Unless it's causing anybody any undue harm I think it's fine to keep both |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know if this is automatically applied to fabricbot or if someone needs to manually update it and this is just a record of what the bot does.