Handle obsolete InterceptorsPreview with .NET 8 RC2 SDK #50797
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
captainsafia
approved these changes
Sep 18, 2023
|
@captainsafia - Failures seem to be due to flaky tests. |
|
@wtgodbe Can you help merge this? Also, not sure if we need tactics at this point. The change here isn't in the product... |
|
@mthalman do we need this in RC2? We snapped the branch yesterday. At this point the |
Bummer, just ahead of the snap. I've retargeted to RC2 branch. Shouldn't need Tactics since this is infrastructure. |
wtgodbe
added
the
tell-mode
ghost
added
the
area-infrastructure
|
Sounds good. We have auto-merges from rc2 -> 8.0 so it'll make it there automatically. We also have auto-merges from 8.0 to main, should this go into main as well? |
Yeah, it'll be needed in main too. |
SteveSandersonMS
added a commit
that referenced
this pull request
Sep 20, 2023
* Handle obsolete InterceptorsPreview with .NET 8 RC2 SDK (#50797) * Quarantine (actually comment out) one of the CanRenderComponentWithPersistedState cases (#50811) See #50810 * Stop processing original response streaming content if user has started navigating away (#50814) * Reproduce #50733 as a failing E2E test * Don't process original request blazor-ssr content if the user has already navigated away * Quarantine (actually comment out) one of the CanRenderComponentWithPersistedState cases See #50810 * Update EventTest.cs * Disable another flaky test --------- Co-authored-by: Matt Thalman <[email protected]> Co-authored-by: Steve Sanderson <[email protected]>
SteveSandersonMS
added a commit
to dotnet-maestro-bot/AspNetCore
that referenced
this pull request
Sep 20, 2023
…0823) * Handle obsolete InterceptorsPreview with .NET 8 RC2 SDK (dotnet#50797) * Quarantine (actually comment out) one of the CanRenderComponentWithPersistedState cases (dotnet#50811) See dotnet#50810 * Stop processing original response streaming content if user has started navigating away (dotnet#50814) * Reproduce dotnet#50733 as a failing E2E test * Don't process original request blazor-ssr content if the user has already navigated away * Quarantine (actually comment out) one of the CanRenderComponentWithPersistedState cases See dotnet#50810 * Update EventTest.cs * Disable another flaky test --------- Co-authored-by: Matt Thalman <[email protected]> Co-authored-by: Steve Sanderson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle obsolete InterceptorsPreview with .NET 8 RC2 SDK
Description
When building the runtime repo using the latest build of .NET 8 RC2 SDK, it produces the following error:
##[error]/vmr/src/aspnetcore/artifacts/source-build/self/src/src/Identity/Core/src/Microsoft.AspNetCore.Http.RequestDelegateGenerator/Microsoft.AspNetCore.Http.RequestDelegateGenerator.RequestDelegateGenerator/GeneratedRouteBuilderExtensions.g.cs(62,10): error CS9137: (NETCORE_ENGINEERING_TELEMETRY=Build) The 'interceptors' experimental feature is not enabled in this namespace. Add '<InterceptorsPreviewNamespaces>$(InterceptorsPreviewNamespaces);Microsoft.AspNetCore.Http.Generated</InterceptorsPreviewNamespaces>' to your project.This is due to a new change from Roslyn: dotnet/roslyn#69848. It replaces the usage of the
InterceptorsPreviewfeature with anInterceptorsPreviewNamespacesproperty that needs to specify the applicable namespace.The use of
InterceptorsPreviewin the project is still needed in order to work with the RC1 SDK. Both need to be specified as support for both versions of the SDK is required to support source-build scenarios. A separate issue will be logged as follow-up to remove the obsoleteInterceptorsPreviewfeature usage.This change is needed for RC2 release.