Rename metrics tag exception.type to error.type #51084
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesNK
requested review from
Tratcher,
halter73,
BrennanConroy and
mgravell
as code owners
ghost
added
the
area-middleware
|
Hi @JamesNK. Please make sure you've updated the PR description to use the Shiproom Template. Also, make sure this PR is not marked as a draft and is ready-to-merge. To learn more about how to prepare a servicing PR click here. |
|
Thanks James. When ready please mail tactics for approval. |
ghost
added
the
area-infrastructure
mkArtakMSFT
added
Servicing-approved
|
Hi @JamesNK. This PR was just approved to be included in the upcoming servicing release. Somebody from the @dotnet/aspnet-build team will get it merged when the branches are open. Until then, please make sure all the CI checks pass and the PR is reviewed. |
|
@wtgodbe can we merge this? |
wtgodbe
approved these changes
Oct 10, 2023
10 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #51029
Rename metrics tag exception.type to error.type
There has been a late change to OpenTelemetry conventions to rename the
exception.typeattribute toerror.type. Because we are doing our best to follow the OTEL conventions, we want ASP.NET Core to use the right name.This change should be done now before the metrics are in a GA release.
Description
Rename the
exception.typeattribute toerror.type.Fixes #51029
Customer Impact
The HTTP metrics in ASP.NET Core follow the OTEL convention.
Regression?
[If yes, specify the version the behavior has regressed from]
Risk
The PR changes a name. Nothing in .NET or ASP.NET Core depends on the name.
Verification
Correct tag name was manually verified by running
dotnet-counters monitor:Packaging changes reviewed?
When servicing release/2.1